Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sensor channel instead of file configuration #87

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

josephmckinsey
Copy link
Contributor

Gets sensor information over a helics bus instead of a file. This makes it more robust in multi-container environments.

@josephmckinsey josephmckinsey changed the title Use sensor channel instead Use sensor channel instead of file configuration Aug 13, 2024
Copy link
Collaborator

@tarekelgindy tarekelgindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, although I haven't tested it locally to see if it works as intended. Only question I have is about the output of the sensors. Is this just for the iee123 system or more generally? Is that why the naming change has been done for sensors?

@@ -65,7 +64,7 @@
"use_smartds": false,
"profile_location": "gadal_ieee123/profiles",
"opendss_location": "gadal_ieee123/qsts",
"sensor_location": "gadal_ieee123/sensors.json",
"sensor_location": "sensors.json",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this location modified by the opendss and profile names still include the gadal_iee123 name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I figured out what was happening here. The problem is this existing_feeder_file just out of frame.

We use the sensor_location in two different ways right now. In one way, we specify where the sensors are on AWS. In the other way, we use it put it on the channel. I was using it for both, which is why is became a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants